linux-kernel - Re: [PATCH] scsi: ufs-qcom: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Jan 2017 17:06:31 -0800
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Vinayak Holikatti <vinholikatti@...il.com>,
        linux-scsi@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs-qcom: Fix module autoload

On 2017-01-02 06:04, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the 
> module
> alias information is not filled. So user-space can't match the 
> registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() 
> macro.
> 
> Before this patch:
> 
> $ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
> alias:          of:N*T*Cqcom,ufshcC*
> alias:          of:N*T*Cqcom,ufshc
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/scsi/ufs/ufs-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index abe617372661..5ff8a6bf6fd3 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1692,6 +1692,7 @@ static const struct of_device_id 
> ufs_qcom_of_match[] = {
>  	{ .compatible = "qcom,ufshc"},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, ufs_qcom_of_match);
> 
>  static const struct dev_pm_ops ufs_qcom_pm_ops = {
>  	.suspend	= ufshcd_pltfrm_suspend,

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project