linux-kernel - Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2017 19:19:56 +0100
From:   Simon Budig <simon.budig@...nelconcepts.de>
To:     Aniroop Mathur <aniroop.mathur@...il.com>
Cc:     Aniroop Mathur <a.mathur@...sung.com>,
        daniel.wagener@...nelconcepts.de, LW@...o-electronics.de,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        SAMUEL SEQUEIRA <s.samuel@...sung.com>,
        Rahul Mahale <r.mahale@...sung.com>
Subject: Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to
 usleep_range for small msecs

On 03/12/16 19:17, Aniroop Mathur wrote:
> Since here we are using msleep(1) which is worse as it sleeps for
> minimum two jiffies so 20 ms on HZ=100 system and we are doing here
> 100 retries if register reading fails. So as you can deduce usleep_range
> will serve better here.
> Explained originally here why to not use msleep for 1-20ms:
> http://lkml.org/lkml/2007/8/3/250

Acked-by: Simon Budig <simon.budig@...nelconcepts.de>

Bye,
        Simon
-- 
     kernel concepts GmbH                 Simon Budig
     Sieghuetter Hauptweg 48              simon.budig@...nelconcepts.de
     D-57072 Siegen                       +49-271-771091-17
     http://www.kernelconcepts.de/
     HR Siegen, HR B 9613; Geschäftsführer: Nils Faerber, Ole Reinhardt




Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)