linux-kernel - Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 04 Jan 2017 10:41:26 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Even Xu <even.xu@...el.com>, jikos@...nel.org,
        benjamin.tissoires@...hat.com, arnd@...db.de,
        andriy.shevchenko@...el.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients
 driver

On Wed, 2017-01-04 at 18:18 +0100, Greg KH wrote:
> On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote:
> > 
> > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote:
> > > 
> > > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote
> > > > 
[...]

> debug should not require a char device node, use debugfs, that is
> what
> it is there for.
> 
> For "calibration", why not use configfs or even sysfs?

We will check on this. There is some legacy with the deployed user
space tools.

> > 
> > Basically the ISH provided a standalone low power processor to
> > developers and manufacturers  to do download some custom algorithms
> > for
> > sensors, which may not be compliant to USB HID sensor
> > specifications
> > (mostly for IOT space). In that case the user space for those can
> > communicate using misc driver interface, without adding new kernel
> > drivers.
> 
> So you hide it behind a char device node?  That's not very
> descriptive
> or easy to understand :)
We added several new sensors to IIO and in process of adding new
sensors to standardize ABI for sensors defined in HID sensor spec.

Customers can develop and download some algorithm which uses output of
several sensors and come up with some fusion sensor to detect some
activity. Either some kernel driver needs to read this and pass this
event to user space or directly let the user space communicate with the
firmware using character device. 
Is there any better way to handle this?

We want customers to use upstream kernel without out of tree kernel
drivers.

Thanks,
Srinivas