linux-kernel - Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2017 14:39:50 -0600
From:   Rob Herring <robh@...nel.org>
To:     Peter Senna Tschudin <peter.senna@...labora.co.uk>
Cc:     Jiri Slaby <jslaby@...e.cz>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Martyn Welch <martyn.welch@...labora.co.uk>,
        Takashi Iwai <tiwai@...e.com>,
        Russell King <linux@...linux.org.uk>,
        Kumar Gala <galak@...eaurora.org>,
        Peter Senna Tschudin <peter.senna@...il.com>,
        Archit Taneja <architt@...eaurora.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        David Miller <davem@...emloft.net>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        enric.balletbo@...labora.com,
        Mauro Carvalho Chehab <mchehab@....samsung.com>,
        Peter Senna Tschudin <peter.senna@...labora.com>,
        Thierry Reding <treding@...dia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Javier Martinez Canillas <javier@...hile0.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        martin.donnelly@...com, Shawn Guo <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Enric Balletbo i Serra <eballetbo@...il.com>,
        Pawel Moll <pawel.moll@....com>,
        David Airlie <airlied@...ux.ie>,
        Yakir Yang <ykk@...k-chips.com>,
        "heiko@...ech.de" <heiko@...ech.de>,
        Thierry Reding <thierry.reding@...il.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp

On Tue, Jan 3, 2017 at 5:34 PM, Peter Senna Tschudin
<peter.senna@...labora.co.uk> wrote:
>  Hi Rob,
>
> Thank you for the review.
>
> On 03 January, 2017 23:51 CET, Rob Herring <robh@...nel.org> wrote:
>
>> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote:
>> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++
>> > display bridge.
>> >
>> > Cc: Martyn Welch <martyn.welch@...labora.co.uk>
>> > Cc: Martin Donnelly <martin.donnelly@...com>
>> > Cc: Javier Martinez Canillas <javier@...hile0.org>
>> > Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
>> > Cc: Rob Herring <robh@...nel.org>
>> > Cc: Fabio Estevam <fabio.estevam@....com>
>> > Signed-off-by: Peter Senna Tschudin <peter.senna@...labora.com>
>> > ---
>> > There was an Acked-by from Rob Herring <robh@...nel.org> for V6, but I changed
>> > the bindings to use i2c_new_secondary_device() so I removed it from the commit
>> > message.
>> >
>> >  .../devicetree/bindings/ge/b850v3-lvds-dp.txt      | 39 ++++++++++++++++++++++
>>
>> Generally, bindings are not organized by vendor. Put in
>> bindings/display/bridge/... instead.
>
> Will change that.
>
>>
>> >  1 file changed, 39 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
>> > new file mode 100644
>> > index 0000000..1bc6ebf
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
>> > @@ -0,0 +1,39 @@
>> > +Driver for GE B850v3 LVDS/DP++ display bridge
>> > +
>> > +Required properties:
>> > +  - compatible : should be "ge,b850v3-lvds-dp".
>>
>> Isn't '-lvds-dp' redundant? The part# should be enough.
>
> b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output?

Humm, b850v3 is the board name? This node should be the name of the bridge chip.

Rob