linux-kernel - Re: [PATCH] mmc: dw_mmc: Fix some coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2017 15:30:56 +0800
From:   Ziyuan <xzy.xu@...k-chips.com>
To:     Joe Perches <joe@...ches.com>, ulf.hansson@...aro.org,
        jh80.chung@...sung.com
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style



On 01/05/2017 02:32 AM, Joe Perches wrote:
> On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote:
>> Let's fix the warnings from checkpatch.pl:
>>
>> - line over 80 characters;
>> - block comments should align the * on each Lines;
>> - statements not starting on a tabstop.
>>
>> Signed-off-by: Ziyuan Xu <xzy.xu@...k-chips.com>
>> ---
>>
>>   drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++----------------
>>   1 file changed, 17 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> []
>> @@ -94,7 +94,8 @@ struct idmac_desc {
>>   
>>   	__le32		des1;	/* Buffer sizes */
>>   #define IDMAC_SET_BUFFER1_SIZE(d, s) \
>> -	((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff)))
>> +	((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \
>> +	 (cpu_to_le32((s) & 0x1fff)))
> Please look to improve code rather than just shut up
> the brainless checkpatch script.
>
> If this is really valuable, it'd probably be better as
> an inline function, or as it's only used once, just
> as direct code in that one place.

Fine, I get it. Thanks for the advice.:-)

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>