linux-kernel - RE: [PATCH V8 1/9] iommu: add IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2017 17:35:25 +0530
From:   "Sricharan" <sricharan@...eaurora.org>
To:     "'Joerg Roedel'" <joro@...tes.org>
Cc:     <mitchelh@...eaurora.org>, <pdaly@...eaurora.org>,
        <vinod.koul@...el.com>, <jgebben@...eaurora.org>,
        <will.deacon@....com>, <linux-kernel@...r.kernel.org>,
        <iommu@...ts.linux-foundation.org>, <linux@...linux.org.uk>,
        <jcrouse@...eaurora.org>, <dan.j.williams@...el.com>,
        <pratikp@...eaurora.org>, <tzeng@...eaurora.org>,
        <linux-arm-kernel@...ts.infradead.org>, <robin.murphy@....com>
Subject: RE: [PATCH V8 1/9] iommu: add IOMMU_PRIV attribute

Hi Joerg,

>-----Original Message-----
>From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@...ts.infradead.org] On Behalf Of Joerg Roedel
>Sent: Friday, January 06, 2017 4:36 PM
>To: Sricharan R <sricharan@...eaurora.org>
>Cc: mitchelh@...eaurora.org; pdaly@...eaurora.org; vinod.koul@...el.com; jgebben@...eaurora.org; will.deacon@....com;
>linux-kernel@...r.kernel.org; iommu@...ts.linux-foundation.org; linux@...linux.org.uk; jcrouse@...eaurora.org;
>dan.j.williams@...el.com; pratikp@...eaurora.org; tzeng@...eaurora.org; linux-arm-kernel@...ts.infradead.org;
>robin.murphy@....com
>Subject: Re: [PATCH V8 1/9] iommu: add IOMMU_PRIV attribute
>
>On Mon, Jan 02, 2017 at 06:42:36PM +0530, Sricharan R wrote:
>> From: Mitchel Humpherys <mitchelh@...eaurora.org>
>>
>> Add the IOMMU_PRIV attribute, which is used to indicate privileged
>> mappings.
>>
>> Reviewed-by: Robin Murphy <robin.murphy@....com>
>> Tested-by: Robin Murphy <robin.murphy@....com>
>> Signed-off-by: Mitchel Humpherys <mitchelh@...eaurora.org>
>> Acked-by: Will Deacon <will.deacon@....com>
>> ---
>>  include/linux/iommu.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 0ff5111..8c15ada 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -31,6 +31,7 @@
>>  #define IOMMU_CACHE	(1 << 2) /* DMA cache coherency */
>>  #define IOMMU_NOEXEC	(1 << 3)
>>  #define IOMMU_MMIO	(1 << 4) /* e.g. things like MSI doorbells */
>> +#define IOMMU_PRIV	(1 << 5) /* privileged */
>
>Since this is a new generic global flag, can you please add a more
>verbose comment telling what a 'privileged' mapping is about in the
>iommu-case? We should have a clear defined semantic for this flag or we
>might end up with different meanings for it with different
>iommu-hardware.

This flag is to inform the iommu api to setup privileged mappings
for the caller which can be accessed only by the master running with
supervisor/privileged permissions and inaccessible to less privileged
execution levels.

i will repost this with comment added.

Regards,
 Sricharan