linux-kernel - Re: [PATCH] iio: adc: imx25-gcq: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 Jan 2017 22:15:34 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Javier Martinez Canillas <javier@....samsung.com>,
        linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>, linux-iio@...r.kernel.org,
        Hartmut Knaack <knaack.h@....de>,
        Markus Pargmann <mpa@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Lee Jones <lee.jones@...aro.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Denis Carikli <denis@...rea.com>
Subject: Re: [PATCH] iio: adc: imx25-gcq: Fix module autoload

On 02/01/17 12:45, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
> alias:          of:N*T*Cfsl,imx25-gcqC*
> alias:          of:N*T*Cfsl,imx25-gcq
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
Applied to the togreg branch of iio.git. Will push out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
> 
>  drivers/iio/adc/fsl-imx25-gcq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index 72b32c1ab257..ea264fa9e567 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -401,6 +401,7 @@ static const struct of_device_id mx25_gcq_ids[] = {
>  	{ .compatible = "fsl,imx25-gcq", },
>  	{ /* Sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, mx25_gcq_ids);
>  
>  static struct platform_driver mx25_gcq_driver = {
>  	.driver		= {
>