linux-kernel - Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 8 Jan 2017 12:31:52 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Alan Stern <stern@...land.harvard.edu>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        usb-storage@...ts.one-eyed-alien.net
Subject: Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote:
> On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> > > The variable Newblk was only being assigned some value but was never
> > > used after that.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> > > ---
> > >   drivers/usb/storage/ene_ub6250.c | 2 --
> > >   1 file changed, 2 deletions(-)
> > 
> > from and signed-off-by does not match :(
> > 
> > Same with your other usb patch...
> > 
> 
> I can add the From: tag in the patch. But this is from the last time we had
> this same conversation.
> 
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html

I can't remember an email thread from last week, or even yesterday, let
alone from almost a year ago.

I suggest you fix your email server so we don't have the same
conversation next week, or use the From: line in the patch which is what
I am expecting people to do for crappy email servers like this. :)

thanks,

greg k-h