linux-kernel - Re: [PATCHv13 0/3] rdmacg: IB/core: rdma controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2017 14:01:26 -0600
From:   Parav Pandit <pandit.parav@...il.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     cgroups@...r.kernel.org, linux-doc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Doug Ledford <dledford@...hat.com>,
        Christoph Hellwig <hch@....de>,
        Liran Liss <liranl@...lanox.com>,
        "Hefty, Sean" <sean.hefty@...el.com>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Haggai Eran <haggaie@...lanox.com>,
        Jonathan Corbet <corbet@....net>, james.l.morris@...cle.com,
        serge@...lyn.com, Or Gerlitz <ogerlitz@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCHv13 0/3] rdmacg: IB/core: rdma controller support

Hi Tejun,

On Mon, Jan 9, 2017 at 7:02 AM, Tejun Heo <tj@...nel.org> wrote:
> On Fri, Dec 02, 2016 at 07:07:14PM +0000, Parav Pandit wrote:
>> Patch is generated and tested against below Doug's linux-rdma
>> git tree.
>> URL: git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git
>> Branch: master
>>
>> Patchset is also compiled and tested against below Tejun's cgroup tree
>> using cgroup v2 mode.
>> URL: git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git
>> Branch: master
>
> Except for the minor nits, all look good to me.  Can you please
> refresh on top of cgroup/for-4.11 and the rdma devel branch?  Please
> note that cgroup/for-4.11 moved the cgroup source files under
> kernel/cgroup/.
>
Thanks for the review.
I will generate new patch in sometime this week with for-4.11 to
address comments and rebase.
I will be renaming cgroup_rdma.c to kernel/cgroup/rdma.c (similar to pids.c)

I will keep the header file name include/linux/cgroup_rdma.h as it is.

> Thanks!
>
> --
> tejun