linux-kernel - Re: [PATCH V5 00/17] blk-throttle: add .low limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2017 16:46:35 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Shaohua Li <shli@...com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, axboe@...com, vgoyal@...hat.com
Subject: Re: [PATCH V5 00/17] blk-throttle: add .low limit

Hello,

Sorry about the long delay.  Generally looks good to me.  Overall,
there are only a few things that I think should be addressed.

* Low limit should default to zero.

* The default values and roles of idle timeout vs. latency target.

I don't think either would be difficult to address.  Oh and a bit more
documentation overall would be nice.

Thanks a lot for the great work and happy new year!

-- 
tejun