linux-kernel - Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Jan 2017 11:56:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ivan Safonov <insafonov@...il.com>
Cc:     Kartikey singh <dr.kartikeynrc@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary
 do-while removed from macro

On Sat, Jan 14, 2017 at 10:53:04PM +0300, Ivan Safonov wrote:
> On 01/14/2017 10:40 PM, Greg KH wrote:
> > On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote:
> > Even better yet, remove it and rebuild the driver and see if it
> > breaks :)
> 
> Only if the code is not between #ifn?def / #endif...

Heh, fair enough, but it usually is a good sign if you do a build, along
with a search, that you are safe to remove something.

thanks,

greg k-h