linux-kernel - Re: [PATCH] power: supply: qcom_smbb: add regulator dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 17:07:56 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tim Bird <tim.bird@...ymobile.com>,
        Bjorn Andersson <bjorn.andersson@...ymobile.com>,
        Andy Gross <andy.gross@...aro.org>,
        Stephen Boyd <stephen.boyd@...aro.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: qcom_smbb: add regulator dependency

Hi Arnd,

On Wed, Jan 18, 2017 at 04:12:10PM +0100, Arnd Bergmann wrote:
> The added regulator dependency in the smbb driver causes build errors
> when regulators are disabled, e.g. in randconfig build testing:
> 
> drivers/power/supply/qcom_smbb.o: In function `smbb_chg_otg_is_enabled':
> qcom_smbb.c:(.text.smbb_chg_otg_is_enabled+0x18): undefined reference to `rdev_get_drvdata'
> drivers/power/supply/qcom_smbb.o: In function `smbb_charger_probe':
> qcom_smbb.c:(.text.smbb_charger_probe+0x410): undefined reference to `devm_regulator_register'
> 
> This adds a Kconfig dependency to avoid the link error.
> 
> Fixes: 61274eff0dde ("power: supply: qcom_smbb: Add otg regulator for control of vbus")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/power/supply/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 59f9841dc246..5f134cf8988c 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -404,6 +404,7 @@ config CHARGER_QCOM_SMBB
>  	depends on MFD_SPMI_PMIC || COMPILE_TEST
>  	depends on OF
>  	depends on EXTCON
> +	depends on REGULATOR
>  	help
>  	  Say Y to include support for the Switch-Mode Battery Charger and
>  	  Boost (SMBB) hardware found in Qualcomm PM8941 PMICs.  The charger

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)