linux-kernel - [PATCH] firewire: core-device: constify device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 21 Jan 2017 22:31:35 +0530
From:   Bhumika Goyal <bhumirks@...il.com>
To:     julia.lawall@...6.fr, stefanr@...6.in-berlin.de,
        linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Cc:     Bhumika Goyal <bhumirks@...il.com>
Subject: [PATCH] firewire: core-device: constify device_type structures

Declare device_type structures as const as they are only stored in the type
field of a device structure. This field is of type const, so device_type
structures having similar properties can be declared const too.

File size before:
  text	   data	    bss	    dec	    hex	filename
   8120	    889	     72	   9081	   2379	drivers/firewire/core-device.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   8248	    761	     72	   9081	   2379	drivers/firewire/core-device.o

Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
---
 drivers/firewire/core-device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c
index f9e3aee..9def58c 100644
--- a/drivers/firewire/core-device.c
+++ b/drivers/firewire/core-device.c
@@ -689,7 +689,7 @@ static void fw_unit_release(struct device *dev)
 	kfree(unit);
 }
 
-static struct device_type fw_unit_type = {
+static const struct device_type fw_unit_type = {
 	.uevent		= fw_unit_uevent,
 	.release	= fw_unit_release,
 };
@@ -849,7 +849,7 @@ static void fw_device_release(struct device *dev)
 	fw_card_put(card);
 }
 
-static struct device_type fw_device_type = {
+static const struct device_type fw_device_type = {
 	.release = fw_device_release,
 };
 
-- 
2.7.4