linux-kernel - Re: [PATCH] ARM: tegra: paz00: fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 11:04:22 +0100
From:   Marc Dietrich <marvin24@....de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Stephen Warren <swarren@...dotorg.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Alexandre Courbot <gnurou@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: tegra: paz00: fix __initdata placement

Hello Dmitry,

Am Sonntag, 22. Januar 2017, 23:43:47 CET schrieb Dmitry Torokhov:
> To have expected effect the __initdata attribute should go after variable
> name and before initializer.`
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  arch/arm/mach-tegra/board-paz00.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-tegra/board-paz00.c
> b/arch/arm/mach-tegra/board-paz00.c index 7478f6fb3664..ea6bff404161 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -23,7 +23,7 @@
> 
>  #include "board.h"
> 
> -static struct property_entry __initdata wifi_rfkill_prop[] = {
> +static struct property_entry wifi_rfkill_prop[] __initdata = {
>  	PROPERTY_ENTRY_STRING("name", "wifi_rfkill"),
>  	PROPERTY_ENTRY_STRING("type", "wlan"),
>  	{ },

you are right according to the documentation, but objdump -s always shows that 
it gets put into the .rodata section. So this patch has no effect, because 
result is always same (and wrong). It's also possible that I'm doing something 
wrong :-) Btw, there are hundreds of such __initdata misplacement in the 
kernel.

Marc

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)