linux-kernel - Re: [V2 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 13:46:57 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Chen Feng <puck.chen@...ilicon.com>
Cc:     xuwei5@...ilicon.com, robh+dt@...nel.org, catalin.marinas@....com,
        will.deacon@....com, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        puck.chen@...mail.com, dan.zhao@...ilicon.com,
        suzhuangluan@...ilicon.com, saberlily.xia@...ilicon.com,
        xuyiping@...ilicon.com, qijiwen@...ilicon.com
Subject: Re: [V2 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

On Tue, Jan 10, 2017 at 03:55:15PM +0800, Chen Feng wrote:
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x0 0x00400000 0x0 0xbfe00000>;
> +	};

The unit-address here is incorrect. The base address of this memory is
not zero.

> +	timer {
> +		compatible = "arm,armv8-timer";
> +		interrupt-parent = <&gic>;
> +		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
> +		clock-frequency = <1920000>;
> +	};

This clock-frequency property should not be required; please remove it.

Your FW should program CNTFRQ_EL0 with the timer frequency.

Thanks,
Mark.