linux-kernel - Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Jan 2017 15:37:58 +0100
From:   Alexander Potapenko <glider@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning

On Wed, Jan 25, 2017 at 3:35 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Wed, Jan 25, 2017 at 03:32:11PM +0100, Alexander Potapenko wrote:
>
>> > @@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size,
>> >         if (likely(!kasan_report_enabled()))
>> >                 return;
>> >
>> > +       disable_trace_on_warning();
>> > +
>> Who is going to enable tracing back after we're done?
>
> The user..
>
>> Note that KASAN errors are not fatal, and the first one may possibly
>> occur quite early.
>
> WARN*() isn't fatal either, and it does the same thing. Note that
> traceoff_on_warning is default disabled. You have to explicitly request
> this.
Ah, that makes sense. Sorry, I wasn't aware of that interface before.



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg