lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Jan 2017 18:13:31 -0800 From: Tai Tri Nguyen <ttnguyen@....com> To: Stephen Boyd <sboyd@...eaurora.org> Cc: Will Deacon <will.deacon@....com>, Mark Rutland <mark.rutland@....com>, LKML <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH] perf: xgene: Include module.h Hi Stephen, On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@...eaurora.org> wrote: > I ran into a build error when I disabled CONFIG_ACPI and tried to > compile this driver: I tried kernel 4.9 and couldn't reproduce the issue. What is the kernel version you are seeing the compilation issue? Regards Tai > > drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class > MODULE_DEVICE_TABLE(of, xgene_pmu_of_match); > ^ > drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] > > Include module.h for the MODULE_DEVICE_TABLE macro that's > implicitly included through ACPI. > > Cc: Tai Nguyen <ttnguyen@....com> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org> > --- > drivers/perf/xgene_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c > index a8ac4bcef2c0..fb3281962a6d 100644 > --- a/drivers/perf/xgene_pmu.c > +++ b/drivers/perf/xgene_pmu.c > @@ -20,6 +20,7 @@ > */ > > #include <linux/acpi.h> > +#include <linux/module.h> > #include <linux/clk.h> > #include <linux/cpumask.h> > #include <linux/interrupt.h> > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Tai
Powered by blists - more mailing lists