linux-kernel - Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jan 2017 07:03:22 -0800
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     riel@...hat.com, linux-kernel@...r.kernel.org
Cc:     mingo@...nel.org, luto@...nel.org, yu-cheng.yu@...el.com,
        bp@...e.de
Subject: Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state

On 01/25/2017 05:57 PM, riel@...hat.com wrote:
>  	/*
> +	 * Restoring SSE/YMM state requires that MXCSR & MXCSR_MASK are saved.
> +	 * Those fields are part of the legacy FP state, and only get saved
> +	 * above if XFEATURES_MASK_FP is set.
> +	 *
> +	 * Copy out those fields if we have SSE/YMM but no FP register data.
> +	 */

Patch looks functionally good to me.  One nit on the comment, though:
Usually XSAVE "state" refers to the state in the CPU while the "area"
refers to the buffer in memory.  Probably best to talk about the "legacy
FP area", not state.

Maybe something like this for the first paragraph:

	MXCSR and MXCSR_MASK are part of the SSE and YMM states and are
	saved/restored along with those states.  However, they are
	located in the legacy FP *area* of the XSAVE buffer.