linux-kernel - Re: [PATCH] ARM: BCM5301X: Add missing Netgear R8000 LEDs and Keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Jan 2017 15:25:02 +0100
From:   Rafał Miłecki <zajec5@...il.com>
To:     AdityaXavier <adityaxavier@...il.com>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] ARM: BCM5301X: Add missing Netgear R8000 LEDs and Keys

Nice work, you're almost there!

Since quite recently ARM DTS patches have to use extra "dts: " prefix,
I understand you could miss that. Please just change your subject from
ARM: BCM5301X: Add missing Netgear R8000 LEDs and Keys
to
ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
and it'll be great.

When bumping patch version it's also nice to include version number in
the tag, e.g.
[PATCH V2]
You can achieve this by e.g.
git format-patch --subject-prefix="PATCH V2" -1


On 28 January 2017 at 14:43, AdityaXavier <adityaxavier@...il.com> wrote:
> From: Aditya Xavier <adityaxavier@...il.com>
>
> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>
> Signed-off-by: Aditya Xavier <adityaxavier@...il.com>
> ---

Ideally, in this place should go a changelog. E.g.:
V2: Update subject and change LED names


>  arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> index 92f8a72..90d4420 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> @@ -27,18 +27,30 @@
>         leds {
>                 compatible = "gpio-leds";
>
> -               power0 {
> +               power-white {
>                         label = "bcm53xx:white:power";
>                         gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>                         linux,default-trigger = "default-on";
>                 };
>
> -               power1 {
> +               power-amber {
>                         label = "bcm53xx:amber:power";
>                         gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>                         linux,default-trigger = "default-off";
>                 };
>
> +               wan-white {
> +                       label = "bcm53xx:white:wan";
> +                       gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
> +                       linux,default-trigger = "default-on";
> +               };
> +
> +               wan-amber {
> +                       label = "bcm53xx:amber:wan";
> +                       gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "default-off";
> +               };
> +
>                 5ghz-1 {
>                         label = "bcm53xx:white:5ghz-1";
>                         gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
> @@ -104,6 +116,12 @@
>                         linux,code = <KEY_RESTART>;
>                         gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>                 };
> +
> +               brightness {
> +                       label = "Backlight";
> +                       linux,code = <KEY_BRIGHTNESS_ZERO>;
> +                       gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
> +               };
>         };
>  };

Changes look OK, thanks!

-- 
Rafał