linux-kernel - Re: [PATCH V6 3/5] OF: Add missing I/O range exception for indirect-IO devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 11:08:20 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     John Garry <john.garry@...wei.com>
Cc:     Rob Herring <robh@...nel.org>,
        "zhichang.yuan" <yuanzhichang@...ilicon.com>,
        catalin.marinas@....com, Will Deacon <will.deacon@....com>,
        frowand.list@...il.com, bhelgaas@...gle.com, rafael@...nel.org,
        Mark Rutland <mark.rutland@....com>, brian.starkey@....com,
        Olof Johansson <olof@...om.net>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        lorenzo.pieralisi@....com,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linuxarm@...wei.com, devicetree@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-serial@...r.kernel.org,
        minyard@....org, liviu.dudau@....com, zourongrong@...il.com,
        gabriele.paoloni@...wei.com, zhichang.yuan02@...il.com,
        kantyzc@....com, Wei Xu <xuwei5@...ilicon.com>
Subject: Re: [PATCH V6 3/5] OF: Add missing I/O range exception for
 indirect-IO devices

On Mon, Jan 30, 2017 at 9:57 AM, John Garry <john.garry@...wei.com> wrote:
> On 27/01/2017 22:03, Rob Herring wrote:
>> On Tue, Jan 24, 2017 at 03:05:23PM +0800, zhichang.yuan wrote:
>>> Signed-off-by: zhichang.yuan <yuanzhichang@...ilicon.com>
>>> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@...wei.com>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>>
>> Shouldn't this be Reviewed-by?
>>
>
> The background is that Zhichang is following a sketch of a re-worked driver
> from Arnd, which Arnd gave Signed-off-by. But this patch does not follow it
> verbatim.
>
> I think this patchset should be resent without Arnd's signature. Or Arnd may
> kindly review and say it's ok.

My general recommendation is that whenever authorship  is not 100% obvious,
then the changelog comment should explain in free form who did what. When
you do that, please leave my Signed-off-by intact and put it on top.
You can also (in addition to explaining it in the text) add an
explanantion behind
the address, such as

Signed-off-by: Arnd Bergmann <arnd@...db.de> # earlier draft

I'll try to get around to do a full review of the series later today.

    Arnd