linux-kernel - Re: [PATCH] i2c: busses: constify i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 13:15:54 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        ludovic.desroches@...el.com, wsa@...-dreams.de,
        sonic.zhang@...log.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, jdelvare@...e.com,
        patrice.chotard@...com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-arm-kernel@...ts.infradead.org, kernel@...inux.com
Subject: Re: [PATCH] i2c: busses: constify i2c_algorithm structures

On 01/27/2017 08:06 PM, Bhumika Goyal wrote:
> Declare i2c_algorithm structures as const as they are only stored in the
> algo field of an i2c_adapter structure. This field is of type const, so
> i2c_algorithm structures having this property can be made const too.
> Done using Coccinelle:
>
...
> diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
> index 6d81c56..a62c14c 100644
> --- a/drivers/i2c/busses/i2c-designware-core.c
> +++ b/drivers/i2c/busses/i2c-designware-core.c
> @@ -822,7 +822,7 @@ static u32 i2c_dw_func(struct i2c_adapter *adap)
>  	return dev->functionality;
>  }
>
> -static struct i2c_algorithm i2c_dw_algo = {
> +static const struct i2c_algorithm i2c_dw_algo = {
>  	.master_xfer	= i2c_dw_xfer,
>  	.functionality	= i2c_dw_func,
>  };

Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>