linux-kernel - Re: [PATCH] perf tools: Create for_each_event{_system,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 13:38:58 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Taeung Song <treeze.taeung@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Wang Nan <wangnan0@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros
 for tracepoints iteration

On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:

SNIP

> > looks almost the same as for_each_event_system macro,
> > what's the difference other than 'ftrace' check?
> 
> Little thing.
> In parse-events.c for_each_event macro contains
> tp_event_has_id() function But this function isn't used in
> util/trace-event-info.c
> 
> > also why's one 'file' and the other 'system'? looks
> 
> Just, I follow the name of each function that use the macros..
> 
> > like we coud have just one macro in here
> > 
> 
> I understood. :)
> How about this ?


looks ok, but can't apply it.. it's probably mangled

jirka