| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jan 2017 15:36:02 -0800
From: Benson Leung <bleung@...omium.org>
To: Gwendal Grignou <gwendal@...omium.org>, bleung@...omium.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver
Hi Gwendal,
Overall, this looks good to me, but please make sure this is based on
upstream, and not the ChromeOS kernel trees.
On 01/30/2017 11:30 AM, Gwendal Grignou wrote:
> Add a kernel driver for GOOG0006, an ACPI driver reporting an event when
> the tablet switch status changes.
>
> On an ACPI based convertible chromebook check evtest display tablet mode
> switch changes:
> Available devices:
> ..
> /dev/input/event3: Tablet Mode Switch
> ..
> Testing ... (interrupt to exit)
> Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 1
> Event: time 1484879712.604360, -------------- SYN_REPORT ------------
> Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 0
> Event: time 1484879715.132228, -------------- SYN_REPORT ------------
> ...
> Check state is updated at resume time when different from suspend time.
>
> Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2
Strip off the gerrit Change-Id: as it is meaningless upstream.
Thanks!
Benson
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists