linux-kernel - Re: [PATCH 06/14] s390/qeth: use atomic_dec_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2017 12:28:34 +0100
From:   Ursula Braun <ubraun@...ux.vnet.ibm.com>
To:     Fabian Frederick <fabf@...net.be>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()

ACK - compile-tested successfully on s390.

On 01/30/2017 07:47 PM, Fabian Frederick wrote:
> instead of atomic_add_unless(value, -1, 0)
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/s390/net/qeth_core_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 315d8a2..9595b90 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3278,7 +3278,7 @@ void qeth_queue_input_buffer(struct qeth_card *card, int index)
>  			atomic_set(&card->force_alloc_skb, 3);
>  			count = newcount;
>  		} else {
> -			atomic_add_unless(&card->force_alloc_skb, -1, 0);
> +			atomic_dec_not_zero(&card->force_alloc_skb);
>  		}
> 
>  		if (!count) {
>