linux-kernel - Re: [PATCH] ARM: orion5x: fix Makefile for linkstation-lschl.dtb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2017 14:05:49 +0100
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Roger Shimizu <rogershimizu@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: orion5x: fix Makefile for linkstation-lschl.dtb

Hi Arnd,
 
 On jeu., févr. 02 2017, Arnd Bergmann <arnd@...db.de> wrote:

> The rename of orion5x-lschl.dts needs to be reflected in the Makefile:
>
> make[3]: *** No rule to make target
> 'arch/arm/boot/dts/orion5x-lschl.dtb', needed by '__build'.

Sorry for that, I did a make dtbs but with the wrong config, (mvebu_v7)
:(

The offending patch is in my mvebu/fixes branch that you didn't applied
yet. How do you want to proceed?

Will you applied this patch just after merging tags/mvebu-fixes-4.10-1 ?

Do you want I resubmit a PR with your patch?

In this case I could also squash your patch in the offending patch.

In any case, if needed you can add my

Acked-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

Thanks,

Gregory


>
> Fixes: 6cfd3cd8d836 ("ARM: dts: orion5x-lschl: More consistent naming on linkstation series")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/arm/boot/dts/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 10eec600cf6b..47208fc5a750 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -633,7 +633,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
>  	orion5x-lacie-ethernet-disk-mini-v2.dtb \
>  	orion5x-linkstation-lsgl.dtb \
>  	orion5x-linkstation-lswtgl.dtb \
> -	orion5x-lschl.dtb \
> +	orion5x-linkstation-lschl.dtb \
>  	orion5x-lswsgl.dtb \
>  	orion5x-maxtor-shared-storage-2.dtb \
>  	orion5x-netgear-wnr854t.dtb \
> -- 
> 2.9.0
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com