linux-kernel - [PATCH] phy: nsp-usb3: select PHYLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  2 Feb 2017 15:32:50 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        Anup Patel <anup.patel@...adcom.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] phy: nsp-usb3: select PHYLIB

Building this driver without PHYLIB fails:

ERROR: "mdio_driver_unregister" [drivers/phy/phy-bcm-nsp-usb3.ko] undefined!
ERROR: "mdio_driver_register" [drivers/phy/phy-bcm-nsp-usb3.ko] undefined!
ERROR: "mdiobus_write" [drivers/phy/phy-bcm-nsp-usb3.ko] undefined!

Unfortunately selecting PHYLIB without NETDEVICES produces a warning:

warning: (NET_DSA && NETLOGIC_XLR_NET && PHY_NSP_USB3) selects PHYLIB which has unmet direct dependencies (NETDEVICES)

so I'm adding a dependency on netdevices here.

Fixes: d7bc1a7d41bf ("phy: Add USB3 PHY support for Broadcom NSP SoC")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/phy/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 853168bb3ba3..87c581f11297 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -509,7 +509,9 @@ config PHY_MESON8B_USB2
 config PHY_NSP_USB3
 	tristate "Broadcom NorthStar plus USB3 PHY driver"
 	depends on OF && (ARCH_BCM_NSP || COMPILE_TEST)
+	depends on NETDEVICES # for PHYLIB
 	select GENERIC_PHY
+	select PHYLIB
 	default ARCH_BCM_NSP
 	help
 	  Enable this to support the Broadcom Northstar plus USB3 PHY.
-- 
2.9.0