linux-kernel - Re: [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Feb 2017 17:05:45 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     João Paulo Rechi Vita <jprvita@...il.com>
Cc:     Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux@...lessm.com,
        João Paulo Rechi Vita <jprvita@...lessm.com>
Subject: Re: [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4}

On Wed, Feb 1, 2017 at 2:21 PM, João Paulo Rechi Vita <jprvita@...il.com> wrote:
> On 27 January 2017 at 10:37, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>> On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita
>> <jprvita@...il.com> wrote:

>>>   Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA"
>>>   Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF"
>>>   Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA"
>>>   Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB"
>>>   Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW"
>>>   Revert "asus-wmi: Create quirk for airplane_mode LED"
>>
>> Don't do this.
>> Each of them will break the working case -> means regression on user experience.
>>
>
> They are being substituted by a generic fix implemented by the
> following two  commits, so the user experience will not change at all
> after the whole series get merged.
>
>>>   asus-wireless: Export ids list
>>>   asus-wmi: Don't register rfkill if ASHS and user bit are present
>>>
>
> Or your point is that these two should come before the reverts? I
> thought patchsets were looked at as an unit from the user experience /
> functionally perspective. Can you please advise on what is the correct
> approach here?

You prepare entire new infrastructure and then you have two options:
1. Remove old stuff and apply new use in one patch
2. Replace old calls by new ones in one patch, and remove not used
anymore old stuff in the other patch.

Choose whatever suits better.

-- 
With Best Regards,
Andy Shevchenko