linux-kernel - Re: [PATCH] iio: adc: handle unknow of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Feb 2017 22:44:26 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Marek Vasut <marek.vasut@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: handle unknow of_device_id data

On Sat, Feb 4, 2017 at 10:11 PM, Marek Vasut <marek.vasut@...il.com> wrote:
> On 02/03/2017 06:01 PM, Arnd Bergmann wrote:
>> diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c
>> index 0c44f72c32a8..331ff9a673be 100644
>> --- a/drivers/iio/adc/rcar-gyroadc.c
>> +++ b/drivers/iio/adc/rcar-gyroadc.c
>> @@ -336,7 +336,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>>       struct device_node *child;
>>       struct regulator *vref;
>>       unsigned int reg;
>> -     unsigned int adcmode, childmode;
>> +     unsigned int adcmode = -1, childmode;
>>       unsigned int sample_width;
>>       unsigned int num_channels;
>>       int ret, first = 1;
>> @@ -366,6 +366,9 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>>                       channels = rcar_gyroadc_iio_channels_3;
>>                       num_channels = ARRAY_SIZE(rcar_gyroadc_iio_channels_3);
>>                       break;
>> +             default:
>> +                     dev_err(dev, "unknown device type");
>
> Is this verbose output really needed ?

I don't care much either way, I was just trying to follow what the function does
for the other failure cases. We can probably drop it though, as this
would indicate
a bug in the driver implementation, while the others are about
incorrect DT data.

    Arnd