linux-kernel - Re: [PATCH] Drivers: staging: speakup: spk_priv.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Feb 2017 20:21:42 -0800
From:   Joe Perches <joe@...ches.com>
To:     Derek Robson <robsonde@...il.com>,
        kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, w.d.hubbs@...il.com, chris@...-brannons.com,
        kirk@...sers.ca, samuel.thibault@...-lyon.org,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        speakup@...ux-speakup.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote:
> On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> > Hi Derek,
> > 
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.10-rc6 next-20170203]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >     #define param_check_int(name, p) __param_check(name, p, int)
> >                                      ^~~~~~~~~~~~~
> >    include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
> >      param_check_##type(name, &(value));       \
> >      ^~~~~~~~~~~~
> >    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> >     module_param_named(ser, synth_acntsa.ser, int, 0444);
> >     ^~~~~~~~~~~~~~~~~~
> >    include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
> >      param_check_##type(name, &(value));       \
> >                                        ^
> >    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> >     module_param_named(ser, synth_acntsa.ser, int, 0444);
> >     ^~~~~~~~~~~~~~~~~~
> >    include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
> >      static const char __param_str_##name[] = prefix #name;  \
> 
> Can anyone tell me what I did wrong?

You removed semicolons from the function prototypes.

-int synth_request_region(u_long, u_long);
-int synth_release_region(u_long, u_long);
+int synth_request_region(unsigned long start, unsigned long n)
+int synth_release_region(unsigned long start, unsigned long n)

> I don't think it was my patch that broke the build.

You should make sure you build test a patch
before sending it on to the list.