linux-kernel - Re: [PATCH v4 0/8] Add sun8i A33 audio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2017 08:49:13 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Mylène Josserand 
        <mylene.josserand@...e-electrons.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, wens@...e.org, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        thomas.petazzoni@...e-electrons.com,
        alexandre.belloni@...e-electrons.com
Subject: Re: [PATCH v4 0/8] Add sun8i A33 audio driver

On Thu, Feb 02, 2017 at 10:24:14AM +0100, Mylène Josserand wrote:
> Hello everyone,
> 
> This a V4 of my Allwinner A33 (sun8i) audio codec driver.
> 
> Tested on "for-next" branch of ASoC repository with some patches
> to apply before this series:
> https://patchwork.kernel.org/patch/9447631/
> https://patchwork.kernel.org/patch/9423999/
> and one of my previous patch (from V2):
> https://patchwork.kernel.org/patch/9521121/
> 
> Changes since V3:
> 	- Rebased my patches under Mark Brown's repo on "for-next" branch.
> 	- Removed the .owner from sun8i-codec driver, reported by KBuild robot
> 	- Updated patch 05/08 according to Rob Herring's review.
> 
> Changes since V2:
> 	- Removed patches from v2 already merged:
> 	commit ebad64d193779 ("ASoC: sun4i-i2s: Increase DMA max burst to 8")
> 	commit 603a0c8af9cb2 ("clk: sunxi-ng: a33: Add CLK_SET_RATE_PARENT to ac-dig")
> 	- Removed "reset-names" from sun4i-i2s driver
> 	- Fixed the build warning from sun8i-codec
> 	- Fixed some various topics such as subject line
> 	for dt bindings patch, renamed the simple-card
> 	and disabled the simple-card.
> 
> Changes since V1:
> 	- Remove the analog codec driver as a better version has been
> 	committed by Chen-Yu Tsai and is already merged.
> 	- Remove the audio-card as simple-card can be used
> 	- The DMA maxburst is set to 8 in the sun4i-i2s instead of
> 	adding the maxburst of 4 in Sun6i dma engine.
> 	- Create a new compatible for sun4i-i2s to handle the reset
> 	line.
> 	- Fix various problems in sun8i-codec driver according to V1's
> 	reviews
> 	- Add the pm_runtime hooks in sun8i-codec driver to prepare/
> 	unprepare clocks.
> 	- Update the DTS according to Chen-Yu's analog codec driver.
> 	- Rename sun8i-codec's clocks to "bus" and "mod"
> 	- The first "delay" issue from V1 is fixed by using a delay
> 	when enabling the headphone amplifier to let the amplifier
> 	being up.
> 
> Patches 1 and 2 add a new compatible "allwinner,sun6i-a31-i2s"
> to handle the reset line for sun4i-i2s driver. It uses a quirk to
> use a version with or without reset lines.
> 
> Patch 3 adds the sun8i codec driver which represents the digital part
> of the A33 codec. It supports only playback features.
> 
> Path 4 fixes the previous issue of a "first time delay" in V1 (see cover
> letter). Do not hesitate if you have comments on this patch.
> 
> Patches 5 adds the dt-bindings documentation for new audio driver
> added in this serie (sun8i-codec).
> 
> Patch 6 adds the cpu DAI, codec and audio nodes to sun8i-a33 device tree.
> 
> Patches 7 and 8 enable the audio on Parrot and Sinlinx's boards.
> 
> The DAI for this A33 codec is the same than for A20: "sun4i-i2s".
> Currently, the sun8i-a33 codec driver handles only the playback feature.
> The other ones (such as capture) and all other interfaces except
> headphone are not supported. I will send a patch to handle the
> capture with microphones in next few weeks.
> 
> Examples of amixer commands:
> 	amixer set 'Headphone' 75%
> 	amixer set 'Headphone' on
> 	amixer set 'DAC' on
> 	amixer set 'Right DAC Mixer RSlot 0' on
> 	amixer set 'Left DAC Mixer LSlot 0' on
> 
> It was tested on Parrot and Sinlinx boards.
> 
> Let me know if you have any comments on this serie.
> 
> Thank you in advance,
> Best regards,
> 
> Mylène Josserand (8):
>   ASoC: sun4i-i2s: Update binding documentation to include A31
>   ASoC: sun4i-i2s: Add quirks to handle a31 compatible
>   ASoC: Add sun8i digital audio codec
>   ASoC: sun8i-codec-analog: Add amplifier event to fix first delay
>   ASoC: codecs: Add sun8i-a33 binding documentation
>   ARM: dts: sun8i: Add audio codec, dai and card for A33
>   ARM: dts: sun8i: parrot: Enable audio nodes
>   ARM: dts: sun8i: sinlinx: Enable audio nodes

Applied the last three. There was a conflict in the last one that I
fixed.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)