linux-kernel - Re: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2017 14:36:11 +0100
From:   Robert Richter <robert.richter@...ium.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
CC:     <linux-arm-kernel@...ts.infradead.org>, <will.deacon@....com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <catalin.marinas@....com>, <akpm@...ux-foundation.org>,
        <hanjun.guo@...aro.org>, <xieyisheng1@...wei.com>,
        <james.morse@....com>
Subject: Re: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA

On 14.12.16 09:11:47, Ard Biesheuvel wrote:
> The NUMA code may get confused by the presence of NOMAP regions within
> zones, resulting in spurious BUG() checks where the node id deviates
> from the containing zone's node id.
> 
> Since the kernel has no business reasoning about node ids of pages it
> does not own in the first place, enable CONFIG_HOLES_IN_ZONE to ensure
> that such pages are disregarded.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

I would rather see a solution other than making pfn_valid checks more
fine grained, but this patch also fixes the issue. So:

Acked-by: Robert Richter <rrichter@...ium.com>