linux-kernel - Re: [PATCH] serial: sh-sci: Temporarily Revert "implement FIFO threshold register setting"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2017 14:06:18 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Peter Hurley <peter@...leysoftware.com>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Ulrich Hecht <ulrich.hecht+renesas@...il.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: sh-sci: Temporarily Revert "implement FIFO
 threshold register setting"

Hi Arnd,

On Tue, Feb 7, 2017 at 2:00 PM, Arnd Bergmann <arnd@...db.de> wrote:
> Patch the first three patches out of seven were applied, up to commit
> a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting"),
> which introduces a new helper function. This is not called until the next
> following patch, so we now get a build warning:
>
> drivers/tty/serial/sh-sci.c:977:12: error: 'scif_set_rtrg' defined but not used [-Werror=unused-function]
>
> The patch is good, but I think we should either apply the following patches
> as well, or revert this one to get a clean build.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> This is mainly a notification that I've applied the revert to my randconfig
> test tree, if you plan to merge the following patches for 4.11, we won't
> need this one.

The follow-up commits were added to tty/tty-next earlier today.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds