lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Feb 2017 23:01:32 -0200 From: Henrique de Moraes Holschuh <hmh@....eng.br> To: Adam Goode <agoode@...gle.com> Cc: Henrique de Moraes Holschuh <ibm-acpi@....eng.br>, Darren Hart <dvhart@...radead.org>, ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org Subject: Re: [ibm-acpi-devel] [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED Hello Adam, I apologise for the delay on answering you. On Tue, 31 Jan 2017, Adam Goode wrote: > On Thu, Jan 19, 2017 at 12:21 PM, Adam Goode <agoode@...gle.com> wrote: > > This allows the control of the red status LED, which is the dot of the "i" > > in the word "ThinkPad" on the outside cover of newer models. > > > > In the manual, both this LED and the power LED are referred to as > > the "system-status indicators" without distinction between the two, so > > I chose "status" as the LED name. I seem to recall this LED had an ACPI interface that was specific for it, and allowed it to on/off/sine-wave? > > Signed-off-by: Adam Goode <agoode@...gle.com> > > > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/ > > thinkpad_acpi.c > > index cacb43fb1df7..6577bf8e5635 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -5611,11 +5611,11 @@ static const char * const > > tpacpi_led_names[TPACPI_LED_NUMLEDS] = { > > "tpacpi::standby", > > "tpacpi::dock_status1", > > "tpacpi::dock_status2", > > - "tpacpi::unknown_led2", > > + "tpacpi::status", > > "tpacpi::unknown_led3", > > "tpacpi::thinkvantage", > > }; > > -#define TPACPI_SAFE_LEDS 0x1081U > > +#define TPACPI_SAFE_LEDS 0x1481U What happens on older Lenovo models (x00, x10, x20 series?)? I think the T410 already had it... Also, please add code to not export it to userspace (as a led class) on IBM. -- Henrique Holschuh
Powered by blists - more mailing lists