linux-kernel - Re: [PATCH v2 06/16] net: stmmac: fix some code style problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Feb 2017 16:06:45 +0100
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/16] net: stmmac: fix some code style problem

On Wed, Feb 08, 2017 at 02:41:58AM -0800, Joe Perches wrote:
> On Wed, 2017-02-08 at 09:31 +0100, Corentin Labbe wrote:
> > Checkpatch complains about some code style problem on stmmac_mdio.c.
> > This patch fix them.
> []
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> []
> > @@ -258,6 +258,7 @@ int stmmac_mdio_register(struct net_device *ndev)
> >  	found = 0;
> >  	for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> >  		struct phy_device *phydev = mdiobus_get_phy(new_bus, addr);
> > +
> >  		if (phydev) {
> >  			int act = 0;
> >  			char irq_num[4];
> 
> Maybe use
> 		if (!phydev)
> 			continue;
> to reduce indentation

Thanks I will do it in a subsequent patch

Regards
Corentin Labbe