linux-kernel - Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2017 09:40:11 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     Roger Quadros <rogerq@...com>, Mark Rutland <mark.rutland@....com>,
        Peter Chen <peter.chen@....com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Heiko Stübner <heiko@...ech.de>,
        Stephen Boyd <stephen.boyd@...aro.org>,
        mail@...iej.szmigiero.name,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gary Bisson <gary.bisson@...ndarydevices.com>,
        Sriram Dash <sriram.dash@....com>,
        Fabio Estevam <festevam@...il.com>,
        Joshua Clayton <stillcompiling@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        Vaibhav Hiremath <vaibhav.hiremath@...aro.org>,
        krzk@...nel.org, mka@...omium.org,
        Alan Stern <stern@...land.harvard.edu>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jack Pham <jackp@...eaurora.org>,
        Pawel Moll <pawel.moll@....com>, linux-pm@...r.kernel.org,
        s.hauer@...gutronix.de, troy.kisky@...ndarydevices.com,
        robh+dt <robh+dt@...nel.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Hans Verkuil <hverkuil@...all.nl>, oscar@...andei.net,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>,
        rjw@...ysocki.net, sre@...nel.org, broonie@...nel.org,
        p.zabel@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On Thu, Feb 09, 2017 at 05:40:50PM +0530, Vivek Gautam wrote:
> On Thu, Feb 9, 2017 at 5:24 PM, Roger Quadros <rogerq@...com> wrote:
> >
> >
> > On 09/02/17 13:53, Roger Quadros wrote:
> >>
> >>
> >> On 08/02/17 22:43, Jack Pham wrote:
> >>> Hi Peter, Sriram, Arnd,
> >>>
> >>> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote:
> >>>> From: Arnd Bergmann <arnd@...db.de>
> >>>>
> >>>> For xhci-hcd platform device, all the DMA parameters are not
> >>>> configured properly, notably dma ops for dwc3 devices. So, set
> >>>> the dma for xhci from sysdev. sysdev is pointing to device that
> >>>> is known to the system firmware or hardware.
> >>>>
> >>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >>>> Signed-off-by: Sriram Dash <sriram.dash@....com>
> >>>> Tested-by: Baolin Wang <baolin.wang@...aro.org>
> >>>> Tested-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> >>>> Tested-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> >>>> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> >>>> ---
> >>>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> >>>> index 6d33b42..7a9c860 100644
> >>>> --- a/drivers/usb/host/xhci-plat.c
> >>>> +++ b/drivers/usb/host/xhci-plat.c
> >>>
> >>>> -   hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
> >>>> +   hcd = __usb_create_hcd(driver, sysdev, &pdev->dev,
> >>>> +                          dev_name(&pdev->dev), NULL);
> >>>
> >>> As mentioned already in [1], usb_create_shared_hcd() is called to create
> >>> the second bus, however it also needs to be converted.
> >>>
> >>> Not exactly as Roger's suggestion but this worked for me:
> >>>
> >>> -       xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev,
> >>> +       xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev,
> >>>                         dev_name(&pdev->dev), hcd);
> >>
> >> But we're creating a shared_hcd and there is an API for that so why not use it
> >> instead of calling __usb_create_hcd()?
> >>
> >
> > Just realized after I pressed send that there is no sysdev parameter
> > for create_shared_hcd().

Roger, does this change also work for you? If it is, please add a
tested-by tag for my v13 patch set.

-- 

Best Regards,
Peter Chen