linux-kernel - Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2017 20:09:46 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion
 to le32

On Thu, Feb 09, 2017 at 10:18:42AM +0000, Carlos Palminha wrote:
> Fixed missing conversion to le32, detected by sparse
> (invalid assignment from int to __le32)
> 
> Signed-off-by: Carlos Palminha <palminha@...opsys.com>
> ---
> v1->v2:
> missed sob line (too late in the night...)
> 
>  drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 041508d6ec6d..4231a0a83097 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -573,7 +573,7 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
>  		}
>  	} else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
>  		/* offset 4 */
> -		ptxdesc->txdw1 |= (0x05) & 0x1f;/*CAM_ID(MAC_ID), default=5;*/
> +		ptxdesc->txdw1 |= cpu_to_le32((0x05) & 0x1f);/*CAM_ID(MAC_ID), default=5;*/

This looks reasonable but it's probably cleaner to say something like:

		ptxdesc->txdw1 |= cpu_to_le32(0x05); /*CAM_ID(MAC_ID), default=5;*/

regards,
dan carpenter