linux-kernel - Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2017 16:46:43 +0100
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@....com>,
        Tommaso Cucinotta <tommaso.cucinotta@...up.it>,
        Luca Abeni <luca.abeni@...tannapisa.it>
Subject: Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task
 activated after the deadline

On 02/13/2017 04:33 PM, Steven Rostedt wrote:
>> +static inline bool dl_is_constrained(struct sched_dl_entity *dl_se)
>> +{
>> +	return dl_se->dl_runtime < dl_se->dl_period;
>> +}
>> +
> Is it ever appropriate for a dl task to have runtime == period? What
> purpose would that serve? Just run the task as FIFO higher than
> everything else.
> 
> Or was this suppose to be dl_deadline < dl_period?

Oooooops, my bad :-(, this was supposed to be dl_deadline < dl_period.

I will send a v2 fixing it, along with the problem in the comment that
peterz mentioned before.

Thanks Steven!

-- Daniel