linux-kernel - Re: [PATCH] tile: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2017 10:01:57 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Chris Metcalf <cmetcalf@...lanox.com>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        linux-next@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] tile: fix build failure

Hi Sudip,

On Mon, 13 Feb 2017 22:58:40 +0000 Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
>
> On Tuesday 24 January 2017 04:56 PM, Chris Metcalf wrote:
> > On 1/24/2017 11:39 AM, Sudip Mukherjee wrote:  
> >> From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> >>
> >> The build of tilegx allmodconfig was failing with errors like:
> >> ../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
> >>   static inline u64 mul_u32_u32(u32 a, u32 b)
> >>                 ^~~
> >> ../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
> >>   static inline u64 mul_u32_u32(u32 a, u32 b)
> >>                                 ^~~
> >> ../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
> >>   static inline u64 mul_u32_u32(u32 a, u32 b)
> >>                                        ^~~
> >> In file included from ../fs/ubifs/ubifs.h:26:0,
> >>                   from ../fs/ubifs/shrinker.c:42:
> >> ../include/linux/math64.h: In function 'mul_u64_u32_shr':
> >> ../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
> >>     function 'mul_u32_u32' [-Werror=implicit-function-declaration]
> >>
> >> The simplest solution was to include the types header file.
> >>
> >> Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and
> >> friends")
> >> Cc: Peter Zijlstra <peterz@...radead.org>
> >> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> >> ---
> >>
> >> build log is at:
> >> https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687
> >>
> >>   arch/tile/include/asm/div64.h | 1 +
> >>   1 file changed, 1 insertion(+)  
> >
> > Acked-by: Chris Metcalf <cmetcalf@...lanox.com>
> >  
> 
> linux-next is still failing for this error. Who will pick this up?

Presumably the tip tree (timers/core).  Added Thomas to cc.

-- 
Cheers,
Stephen Rothwell