linux-kernel - Re: [PATCH 01/15] Staging: rtl8192u: ieee80211: ieee80211_wx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 10:38:29 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Derek Robson <robsonde@...il.com>
Cc:     binoy.jayan@...aro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/15] Staging: rtl8192u: ieee80211: ieee80211_wx.c -
 style fix

On Thu, Feb 16, 2017 at 06:30:51PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 87 ++++++++++++-----------
>  1 file changed, 47 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> index 563d7fed6e1c..0d24158e038a 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> @@ -1,34 +1,34 @@
>  /******************************************************************************
> -
> -  Copyright(c) 2004 Intel Corporation. All rights reserved.
> -
> -  Portions of this file are based on the WEP enablement code provided by the
> -  Host AP project hostap-drivers v0.1.3
> -  Copyright (c) 2001-2002, SSH Communications Security Corp and Jouni Malinen
> -  <jkmaline@...hut.fi>
> -  Copyright (c) 2002-2003, Jouni Malinen <jkmaline@...hut.fi>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> -
> -  This program is distributed in the hope that it will be useful, but WITHOUT
> -  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> -  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> -  more details.
> -
> -  You should have received a copy of the GNU General Public License along with
> -  this program; if not, write to the Free Software Foundation, Inc., 59
> -  Temple Place - Suite 330, Boston, MA  02111-1307, USA.
> -
> -  The full GNU General Public License is included in this distribution in the
> -  file called LICENSE.
> -
> -  Contact Information:
> -  James P. Ketrenos <ipw2100-admin@...ux.intel.com>
> -  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
> -
> -******************************************************************************/
> + *
> + *  Copyright(c) 2004 Intel Corporation. All rights reserved.
> + *
> + *  Portions of this file are based on the WEP enablement code provided by the
> + *  Host AP project hostap-drivers v0.1.3
> + *  Copyright (c) 2001-2002, SSH Communications Security Corp and Jouni Malinen
> + *  <jkmaline@...hut.fi>
> + *  Copyright (c) 2002-2003, Jouni Malinen <jkmaline@...hut.fi>
> + *
> + *  This program is free software; you can redistribute it and/or modify it
> + *  under the terms of version 2 of the GNU General Public License as
> + *  published by the Free Software Foundation.
> + *
> + *  This program is distributed in the hope that it will be useful, but WITHOUT
> + *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + *  more details.
> + *
> + *  You should have received a copy of the GNU General Public License along with
> + *  this program; if not, write to the Free Software Foundation, Inc., 59
> + *  Temple Place - Suite 330, Boston, MA  02111-1307, USA.
> + *
> + *  The full GNU General Public License is included in this distribution in the
> + *  file called LICENSE.
> + *
> + *  Contact Information:
> + *  James P. Ketrenos <ipw2100-admin@...ux.intel.com>
> + *  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
> + *
> + ******************************************************************************/
>  #include <linux/wireless.h>
>  #include <linux/kmod.h>
>  #include <linux/slab.h>
> @@ -108,7 +108,8 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee,
>  	/* Add frequency/channel */
>  	iwe.cmd = SIOCGIWFREQ;
>  /*	iwe.u.freq.m = ieee80211_frequency(network->channel, network->mode);
> -	iwe.u.freq.e = 3; */
> + *	iwe.u.freq.e = 3;
> + */

Just delete commented out code, no need to go and make it "pretty".

Same thing for a number of the patches in this series.

thanks,

greg k-h