linux-kernel - Re: [PATCH] ASLA: emu10k1: constify snd_emux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Feb 2017 21:35:27 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure

On Feb 19 2016 19:21, Bhumika Goyal wrote:
> Declare snd_emux_operators structure as const as it is only copied into
> another structure. So, snd_emux_operators structures having this property
> can be made const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

...The 'ASLA' reminds me of the god in Indian myth[0]. When Buddhism 
disseminated to Japan via China, the god changed its name and became the 
god in Japanese Buddhism, too.

...I'm just a kidding. The title should be fixed with 'ALSA' ;)

> ---
>  sound/pci/emu10k1/emu10k1_callback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/emu10k1/emu10k1_callback.c b/sound/pci/emu10k1/emu10k1_callback.c
> index d2c7ea3..aa2cc27 100644
> --- a/sound/pci/emu10k1/emu10k1_callback.c
> +++ b/sound/pci/emu10k1/emu10k1_callback.c
> @@ -61,7 +61,7 @@ static struct snd_emux_voice *get_voice(struct snd_emux *emux,
>  /*
>   * set up operators
>   */
> -static struct snd_emux_operators emu10k1_ops = {
> +static const struct snd_emux_operators emu10k1_ops = {
>  	.owner =	THIS_MODULE,
>  	.get_voice =	get_voice,
>  	.prepare =	start_voice,

[0] https://en.wikipedia.org/wiki/Asura
[1] https://en.wikipedia.org/wiki/Asura_(Buddhism)


Regards

Takashi Sakamoto