linux-kernel - Re: [PATCH] gpio: aspeed: Add debounce support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Feb 2017 00:36:14 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrew Jeffery <andrew@...id.au>
Cc:     kbuild-all@...org, Linus Walleij <linus.walleij@...aro.org>,
        Andrew Jeffery <andrew@...id.au>,
        Joel Stanley <joel@....id.au>,
        Alexandre Courbot <gnurou@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org
Subject: Re: [PATCH] gpio: aspeed: Add debounce support

Hi Andrew,

[auto build test WARNING on next-20170220]
[cannot apply to gpio/for-next v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.10]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrew-Jeffery/gpio-aspeed-Add-debounce-support/20170220-231310
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-aspeed.c: In function 'aspeed_gpio_set_config':
>> drivers/gpio/gpio-aspeed.c:733:9: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return rc;
            ^~

vim +/rc +733 drivers/gpio/gpio-aspeed.c

   717		switch (param) {
   718		case PIN_CONFIG_INPUT_DEBOUNCE:
   719			rc = aspeed_gpio_set_debounce(chip, offset, arg);
   720			break;
   721		case PIN_CONFIG_BIAS_DISABLE:
   722		case PIN_CONFIG_BIAS_PULL_DOWN:
   723		case PIN_CONFIG_DRIVE_STRENGTH:
   724			rc = pinctrl_gpio_set_config(offset, config);
   725			break;
   726		case PIN_CONFIG_DRIVE_OPEN_DRAIN:
   727		case PIN_CONFIG_DRIVE_OPEN_SOURCE:
   728			/* Fallthrough for emulation, as per datasheet */
   729		default:
   730			rc = -ENOTSUPP;
   731		}
   732	
 > 733		return rc;
   734	}
   735	
   736	/*
   737	 * Any banks not specified in a struct aspeed_bank_props array are assumed to
   738	 * have the properties:
   739	 *
   740	 *     { .input = 0xffffffff, .output = 0xffffffff }
   741	 */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (58763 bytes)