linux-kernel - Re: [PATCH] ATM: dts: at91: sama5d2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2017 09:42:41 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     nicolas.ferre@...el.com, boris.brezillon@...e-electrons.com,
        robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
        ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
        ludovic.desroches@...el.com, cyrille.pitchen@...el.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Hi,

There is a typo in your subject, please fix.

On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote:
> Add pwm controller bindings for sam5d2_xplained
> and enable it.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
>  arch/arm/boot/dts/sama5d2.dtsi                      | 8 ++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> index 9fc270f..493ea29 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> @@ -318,6 +318,10 @@
>  				};
>  			};
>  
> +			pwm0: pwm@...2c000 {
> +				status = "okay";
> +			};
> +
>  			flx0: flexcom@...34000 {
>  				atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>  				status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index cd459e8..e88785e 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1098,6 +1098,14 @@
>  				status = "disabled";
>  			};
>  
> +			pwm0: pwm@...2c000 {
> +				compatible = "atmel,sama5d2-pwm";

This compatible is not documented and is not used in any driver. Is that
really working?

> +				reg = <0xf802c000 0x4000>;
> +				interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#pwm-cells = <3>;
> +				clocks = <&pwm_clk>;
> +			};
> +
>  			sfr: sfr@...30000 {
>  				compatible = "atmel,sama5d2-sfr", "syscon";
>  				reg = <0xf8030000 0x98>;
> -- 
> 2.7.4
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com