linux-kernel - Re: [PATCH -next] input/touchscreen: add header file to fix ad7879.c build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Feb 2017 10:51:11 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH -next] input/touchscreen: add header file to fix ad7879.c
 build errors

On Fri, Feb 24, 2017 at 10:30:22AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Add header file to fix these build errors:
> 
> ../drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt':
> ../drivers/input/touchscreen/ad7879.c:505:2: error: implicit declaration of function 'device_property_read_u32' [-Werror=implicit-function-declaration]
>   err = device_property_read_u32(dev, "adi,resistance-plate-x", &tmp);
>   ^
> ../drivers/input/touchscreen/ad7879.c:512:2: error: implicit declaration of function 'device_property_read_u8' [-Werror=implicit-function-declaration]
>   device_property_read_u8(dev, "adi,first-conversion-delay",
>   ^
> ../drivers/input/touchscreen/ad7879.c:521:2: error: implicit declaration of function 'device_property_read_bool' [-Werror=implicit-function-declaration]
>   ts->swap_xy = device_property_read_bool(dev, "touchscreen-swapped-x-y");
>   ^
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Applied, thank you.

> Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc:	linux-input@...r.kernel.org
> Cc:	Michael Hennerich <michael.hennerich@...log.com>
> ---
>  drivers/input/touchscreen/ad7879.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20170224.orig/drivers/input/touchscreen/ad7879.c
> +++ linux-next-20170224/drivers/input/touchscreen/ad7879.c
> @@ -26,6 +26,7 @@
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
> +#include <linux/property.h>
>  #include <linux/regmap.h>
>  #include <linux/slab.h>
>  #include <linux/gpio.h>

-- 
Dmitry