linux-kernel - Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Feb 2017 19:57:01 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Codrut Grosu <codrut.cristian.grosu@...il.com>
cc:     perex@...ex.cz, tiwai@...e.com, lgirdwood@...il.com,
        broonie@...nel.org, swarren@...dotorg.org,
        thierry.reding@...il.com, gnurou@...il.com, Julia.Lawall@...6.fr,
        nicoleotsuka@...il.com, alsa-devel@...a-project.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should
 align the * on each line' message

The subject line is not very accurate.  You don't remove the message, in
the sense of picking it up and putting it somewhere else.  You adjust the
code in some way such that the error no longer occurs.  So it would be
better to say what adjustment you have done.  Something like line up *s in
block comments.

julia



On Sat, 25 Feb 2017, Codrut Grosu wrote:

> This was reported by checkpatch.pl
>
> Signed-off-by: Codrut Grosu <codrut.cristian.grosu@...il.com>
> ---
>  sound/soc/tegra/tegra_alc5632.c | 2 +-
>  sound/soc/tegra/tegra_rt5640.c  | 2 +-
>  sound/soc/tegra/tegra_rt5677.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
> index 0509902..1f648f9 100644
> --- a/sound/soc/tegra/tegra_alc5632.c
> +++ b/sound/soc/tegra/tegra_alc5632.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
> + * tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
>   *
>   * Copyright (C) 2011 The AC100 Kernel Team <ac100@...ts.lauchpad.net>
>   * Copyright (C) 2012 - NVIDIA, Inc.
> diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c
> index 93a3568..cf706d0 100644
> --- a/sound/soc/tegra/tegra_rt5640.c
> +++ b/sound/soc/tegra/tegra_rt5640.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
> + * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
>   *
>   * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
>   *
> diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
> index ebf58d0..0ed2eca 100644
> --- a/sound/soc/tegra/tegra_rt5677.c
> +++ b/sound/soc/tegra/tegra_rt5677.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
> + * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
>   *
>   * Copyright (c) 2014, The Chromium OS Authors.  All rights reserved.
>   *
> 1.9.1
>
>