linux-kernel - Re: [PATCH v2] staging: xgifb: correct the multiple line dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Feb 2017 19:04:16 -0800
From:   Joe Perches <joe@...ches.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>,
        arnaud.patard@...-net.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v2] staging: xgifb: correct the multiple line dereference

On Sat, 2017-02-25 at 05:11 +0530, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference...
> And If there is boolean operator then it is fixed by Splitting line at
> boolean operator.This is a coding style error.
> The changes are made such that the other errors does not generate
> beacause of this change like line exceeding 80 characters length.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
>  changes in v2
>  - changes done such that no other errors can generate.
> ---
>  drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
>  drivers/staging/xgifb/vb_setmode.c  | 14 +++++++-------
>  2 files changed, 16 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6930f7eb741b..651987398d42 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
>  			}
>  
>  			if ((filter >= 0) && (filter <= 7)) {
> +				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
> +
>  				pr_debug("FilterTable[%d]-%d: %*ph\n",
>  					 filter_tb, filter,
> -					 4, XGI_TV_filter[filter_tb].
> -						   filter[filter]);
> +					 4, f);

Do please rewrap these appropriately.  i.e.:

				pr_debug(""FilterTable[%d]-%d: %*ph\n",
 					 filter_tb, filter, 4, f);

>  				xgifb_reg_set(
>  					XGIPART2,
>  					0x35,
> -					(XGI_TV_filter[filter_tb].
> -						filter[filter][0]));
> -				xgifb_reg_set(
> +					(f[0]));


and:
				xgifb_reg_set(XGIPART2, 0x35, f[0]);

> +			        xgifb_reg_set(
>  					XGIPART2,
>  					0x36,
> -					(XGI_TV_filter[filter_tb].
> -						filter[filter][1]));
> -				xgifb_reg_set(
> +					(f[1]));

				xgifb_reg_set(XGIPART2, 0x36, f[1]);

etc...