linux-kernel - Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Feb 2017 16:10:45 +0800
From:   Yunlong Song <yunlong.song@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
CC:     Chao Yu <yuchao0@...wei.com>, <cm224.lee@...sung.com>,
        <chao@...nel.org>, <sylinux@....com>, <miaoxie@...wei.com>,
        <bintian.wang@...wei.com>, <linux-fsdevel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG
 to macro

On 2017/2/25 2:12, Jaegeuk Kim wrote:

> 
> This is to handle only one case in which:
> 
> 1. uses old kernel without this flag,
> 2. calls fsync and gets sudden power-cut,
> 3. updates new kernel having this flag before mount.
> 
> Then, if we do not check this flag at mount time, we will lose the last fsync'ed
> node blocks.
> 

So I just send a v2 patch to only change to macro in fill_node_footer_blkaddr and
allocate_segment_by_default, these two functions are called frequently, so it is
better to use macro code. And I remain the original checking code in is_recoverable_dnode,
this function is called only once after mount, it's OK.

-- 
Thanks,
Yunlong Song