linux-kernel - Re: [PATCH] asm-generic: Force cast get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2017 16:52:41 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Stephen Boyd <stephen.boyd@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Subject: Re: [PATCH] asm-generic: Force cast get_user() setting x to 0

On Sat, Feb 25, 2017 at 2:24 AM, Stephen Boyd <stephen.boyd@...aro.org> wrote:
> Quoting Stephen Boyd (2017-02-17 08:52:29)
>> If we call get_user() with an __le* or __be* type sparse will
>> complain when we assign the result to 0 on the faulting path.
>> Let's force cast here so that sparse doesn't complain. This
>> mirrors what we do in __get_user() as well.
>>
>> Signed-off-by: Stephen Boyd <stephen.boyd@...aro.org>
>> ---
>>
>> I made a similar fix to arm64 headers, and it looks like asm-generic
>> would need the same fix.
>
> I suppose we can ignore this. I was using sparse v0.5.0 but it seems
> that later versions of sparse don't complain here anymore as Luc has
> pointed out.

Ok, thanks for the follow-up.

   Arnd