linux-kernel - Re: [PATCH v6 4/6] i2c: designware: introducing I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2017 11:24:25 -0600
From:   Rob Herring <robh@...nel.org>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>
Cc:     wsa@...-dreams.de, mark.rutland@....com,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ramiro.Oliveira@...opsys.com, Joao.Pinto@...opsys.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions

On Wed, Feb 15, 2017 at 12:22:13PM +0000, Luis Oliveira wrote:
> - Definitions were added to core library
> - A example was added to designware-core.txt Documentation that shows
>   how the slave can be setup using DTS
> 
> SLAVE related definitions were added to the core of the controller.
> 
> Signed-off-by: Luis Oliveira <lolivei@...opsys.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> V5->V6
> - Included an example of use in the device tree binding document
> 
>  .../devicetree/bindings/i2c/i2c-designware.txt     | 16 +++++++++-
>  drivers/i2c/busses/i2c-designware-core.h           | 35 ++++++++++++++++++++--
>  2 files changed, 48 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> index fee26dc3e858..c6f1d9a63d18 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> @@ -20,7 +20,7 @@ Optional properties :
>   - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds.
>     This value which is by default 300ns is used to compute the tHIGH period.
>  
> -Example :
> +Examples :
>  
>  	i2c@...00 {
>  		#address-cells = <1>;
> @@ -43,3 +43,17 @@ Example :
>  		i2c-sda-falling-time-ns = <300>;
>  		i2c-scl-falling-time-ns = <300>;
>  	};
> +
> +	i2c@...20000 {

Drop leading 0. With that, for the binding:

Acked-by: Rob Herring <robh@...nel.org>

> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x2000 0x100>;
> +		clock-frequency = <400000>;
> +		clocks = <&i2cclk>;
> +		interrupts = <0>;
> +
> +		eeprom@64 {
> +			compatible = "linux,slave-24c02";
> +			reg = <0x40000064>;
> +		};
> +	};