linux-kernel - Re: [PATCH] serial: 8250_dw: Honor clk_round_rate errors in dw8250_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2017 15:55:10 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_dw: Honor clk_round_rate errors in dw8250_set_termios

On Tue, Feb 28, 2017 at 5:17 AM, Heiko Stuebner <heiko@...ech.de> wrote:
> clk_round_rate returns a signed long and may possibly return errors
> in it, for example if there is no possible rate.
>
> Till now dw8250_set_termios ignored any error, the signednes and would
> just use the value as input to clk_set_rate. This of course falls apart
> if there is an actual error, so check for errors and only try to set
> a rate if the value is actually valid.
>

FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
>  drivers/tty/serial/8250/8250_dw.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 6ee55a2d47bb..223ac234ddb2 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -257,7 +257,7 @@ static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
>  {
>         unsigned int baud = tty_termios_baud_rate(termios);
>         struct dw8250_data *d = p->private_data;
> -       unsigned int rate;
> +       long rate;
>         int ret;
>
>         if (IS_ERR(d->clk) || !old)
> @@ -265,7 +265,10 @@ static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
>
>         clk_disable_unprepare(d->clk);
>         rate = clk_round_rate(d->clk, baud * 16);
> -       ret = clk_set_rate(d->clk, rate);
> +       if (rate < 0)
> +               ret = rate;
> +       else
> +               ret = clk_set_rate(d->clk, rate);
>         clk_prepare_enable(d->clk);
>
>         if (!ret)
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko