linux-kernel - Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2017 16:24:37 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly
 non-modular"

On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d.
> 
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  lib/test_sort.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/test_sort.c b/lib/test_sort.c
> index 4db3911db50ace76..d389c1cc2f6cf795 100644
> --- a/lib/test_sort.c
> +++ b/lib/test_sort.c
> @@ -1,11 +1,8 @@
>  #include <linux/sort.h>
>  #include <linux/slab.h>
> -#include <linux/init.h>
> +#include <linux/module.h>
> 

>  
> -/*
> - * A simple boot-time regression test
> - * License: GPL
> - */
> +/* a simple boot-time regression test */

I would leave this piece as is now.

The rest is okay.

>  
>  #define TEST_LEN 1000
>  
> @@ -41,4 +38,6 @@ static int __init test_sort_init(void)
>  	kfree(a);
>  	return err;
>  }
> -subsys_initcall(test_sort_init);
> +
> +module_init(test_sort_init);
> +MODULE_LICENSE("GPL");

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy